On Sun, 24 Nov 2019 12:39:26 +0200
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> > @@ -1346,7 +1355,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
> > funcs->commit(encoder);
> > }
> >
> > - drm_atomic_bridge_chain_enable(encoder->bridge, old_state);
> > + drm_atomic_bridge_chain_enable(bridge, old_state);
> > }
> >
> > drm_atomic_helper_commit_writebacks(dev, old_state);
> > diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c
> > index 80d88a55302e..4fe9e723e227 100644
> > --- a/drivers/gpu/drm/drm_encoder.c
> > +++ b/drivers/gpu/drm/drm_encoder.c
> > @@ -167,9 +167,10 @@ void drm_encoder_cleanup(struct drm_encoder *encoder)
> > */
> >
> > if (encoder->bridge) {
> > - struct drm_bridge *bridge = encoder->bridge;
> > + struct drm_bridge *bridge;
> > struct drm_bridge *next;
> >
> > + bridge = drm_bridge_chain_get_first_bridge(encoder);
> > while (bridge) {
> > next = bridge->next;
>
> Shouldn't this have been addressed in the previous patch ?
>
It should and I will update patch 6 accordingly. This being said, it's
not a big deal since the code is patched to use
list_for_each_entry_safe() in patch 7 ;-).
