Re: [PATCH 3/3] ARM: dts: at91: Remove the USB EP child node

[Robin Murphy <robin.murphy@xxxxxxx>]

On 07/11/2019 3:31 pm, Gregory CLEMENT wrote:
> The endpoint configuration used to be stored in the device tree,
> however the configuration depend on the "version" of the controller
> itself.
>
> Then the EP child node are useless and describe as deprecated in the
> documentation binding: remove all the nodes from the SoC device tree
> file.

Just as a drive-by comment, it's presumably worth getting rid of the 
#address-cells and #size-cells properties too (here and in the binding 
example).

Robin.

> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/at91sam9g45.dtsi |  52 -------------
>   arch/arm/boot/dts/at91sam9rl.dtsi  |  52 -------------
>   arch/arm/boot/dts/at91sam9x5.dtsi  |  52 -------------
>   arch/arm/boot/dts/sama5d2.dtsi     | 118 -----------------------------
>   arch/arm/boot/dts/sama5d3.dtsi     | 105 -------------------------
>   arch/arm/boot/dts/sama5d4.dtsi     | 118 -----------------------------
>   6 files changed, 497 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 691c95ea6175..63bfe546cd8d 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -1204,58 +1204,6 @@
>   				clocks = <&udphs_clk>, <&utmi>;
>   				clock-names = "pclk", "hclk";
>   				status = "disabled";
> -
> -				ep@0 {
> -					reg = <0>;
> -					atmel,fifo-size = <64>;
> -					atmel,nb-banks = <1>;
> -				};
> -
> -				ep@1 {
> -					reg = <1>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@2 {
> -					reg = <2>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@3 {
> -					reg = <3>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@4 {
> -					reg = <4>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@5 {
> -					reg = <5>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@6 {
> -					reg = <6>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
>   			};
>   
>   			clk32k: sckc@fffffd50 {
> diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts/at91sam9rl.dtsi
> index 8643b7151565..e118bacb7d7c 100644
> --- a/arch/arm/boot/dts/at91sam9rl.dtsi
> +++ b/arch/arm/boot/dts/at91sam9rl.dtsi
> @@ -308,58 +308,6 @@
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 22>, <&pmc PMC_TYPE_CORE PMC_UTMI>;
>   				clock-names = "pclk", "hclk";
>   				status = "disabled";
> -
> -				ep@0 {
> -					reg = <0>;
> -					atmel,fifo-size = <64>;
> -					atmel,nb-banks = <1>;
> -				};
> -
> -				ep@1 {
> -					reg = <1>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@2 {
> -					reg = <2>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@3 {
> -					reg = <3>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@4 {
> -					reg = <4>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@5 {
> -					reg = <5>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@6 {
> -					reg = <6>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
>   			};
>   
>   			dma0: dma-controller@ffffe600 {
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index 7c2eb93f8cac..685a1b9f3ae5 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -876,58 +876,6 @@
>   				clocks = <&pmc PMC_TYPE_CORE PMC_UTMI>, <&pmc PMC_TYPE_PERIPHERAL 23>;
>   				clock-names = "hclk", "pclk";
>   				status = "disabled";
> -
> -				ep@0 {
> -					reg = <0>;
> -					atmel,fifo-size = <64>;
> -					atmel,nb-banks = <1>;
> -				};
> -
> -				ep@1 {
> -					reg = <1>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@2 {
> -					reg = <2>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <2>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@3 {
> -					reg = <3>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@4 {
> -					reg = <4>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -				};
> -
> -				ep@5 {
> -					reg = <5>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
> -
> -				ep@6 {
> -					reg = <6>;
> -					atmel,fifo-size = <1024>;
> -					atmel,nb-banks = <3>;
> -					atmel,can-dma;
> -					atmel,can-isoc;
> -				};
>   			};
>   
>   			watchdog: watchdog@fffffe40 {
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 2e2c1a7b1d1d..daafcffbe033 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -122,124 +122,6 @@
>   			clocks = <&pmc PMC_TYPE_PERIPHERAL 42>, <&pmc PMC_TYPE_CORE PMC_UTMI>;
>   			clock-names = "pclk", "hclk";
>   			status = "disabled";
> -
> -			ep@0 {
> -				reg = <0>;
> -				atmel,fifo-size = <64>;
> -				atmel,nb-banks = <1>;
> -			};
> -
> -			ep@1 {
> -				reg = <1>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@2 {
> -				reg = <2>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@3 {
> -				reg = <3>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@4 {
> -				reg = <4>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@5 {
> -				reg = <5>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@6 {
> -				reg = <6>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@7 {
> -				reg = <7>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@8 {
> -				reg = <8>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@9 {
> -				reg = <9>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@10 {
> -				reg = <10>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@11 {
> -				reg = <11>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@12 {
> -				reg = <12>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@13 {
> -				reg = <13>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@14 {
> -				reg = <14>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@15 {
> -				reg = <15>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
>   		};
>   
>   		usb1: ohci@400000 {
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index f770aace0efd..dfd095f33f95 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1402,111 +1402,6 @@
>   			clocks = <&udphs_clk>, <&utmi>;
>   			clock-names = "pclk", "hclk";
>   			status = "disabled";
> -
> -			ep@0 {
> -				reg = <0>;
> -				atmel,fifo-size = <64>;
> -				atmel,nb-banks = <1>;
> -			};
> -
> -			ep@1 {
> -				reg = <1>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@2 {
> -				reg = <2>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@3 {
> -				reg = <3>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -			};
> -
> -			ep@4 {
> -				reg = <4>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -			};
> -
> -			ep@5 {
> -				reg = <5>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -			};
> -
> -			ep@6 {
> -				reg = <6>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -			};
> -
> -			ep@7 {
> -				reg = <7>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -			};
> -
> -			ep@8 {
> -				reg = <8>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@9 {
> -				reg = <9>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@10 {
> -				reg = <10>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@11 {
> -				reg = <11>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@12 {
> -				reg = <12>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@13 {
> -				reg = <13>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@14 {
> -				reg = <14>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
> -
> -			ep@15 {
> -				reg = <15>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -			};
>   		};
>   
>   		usb1: ohci@600000 {
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 6ab27a7b388d..0ece6b22d287 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -105,124 +105,6 @@
>   			clocks = <&pmc PMC_TYPE_PERIPHERAL 47>, <&pmc PMC_TYPE_CORE PMC_UTMI>;
>   			clock-names = "pclk", "hclk";
>   			status = "disabled";
> -
> -			ep@0 {
> -				reg = <0>;
> -				atmel,fifo-size = <64>;
> -				atmel,nb-banks = <1>;
> -			};
> -
> -			ep@1 {
> -				reg = <1>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@2 {
> -				reg = <2>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <3>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@3 {
> -				reg = <3>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@4 {
> -				reg = <4>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@5 {
> -				reg = <5>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@6 {
> -				reg = <6>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@7 {
> -				reg = <7>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-dma;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@8 {
> -				reg = <8>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@9 {
> -				reg = <9>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@10 {
> -				reg = <10>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@11 {
> -				reg = <11>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@12 {
> -				reg = <12>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@13 {
> -				reg = <13>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@14 {
> -				reg = <14>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
> -
> -			ep@15 {
> -				reg = <15>;
> -				atmel,fifo-size = <1024>;
> -				atmel,nb-banks = <2>;
> -				atmel,can-isoc;
> -			};
>   		};
>   
>   		usb1: ohci@500000 {