Hello Hanjie, On Fri, Nov 22, 2019 at 7:55 AM Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote: [...] > dt-bindings: phy: Add Amlogic G12A USB2 PHY Bindings > dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings > phy: amlogic: Add Amlogic A1 USB2 PHY Driver drivers/phy/amlogic/phy-meson-g12a-usb2.c seems very similar to the A1 USB2 PHY you are introducing here. > usb: dwc3: Add Amlogic A1 DWC3 glue drivers/usb/dwc3/dwc3-meson-g12a.c is also very similar to the dwc3 glue. I have two questions: - how is the PHY and the dwc3 glue different from G12A (or SM1)? - why do we need a separate set of new drivers (instead of updating the existing drivers)? We try to use one driver for the same IP block, even if there are several revisions with small differences (for example the SAR ADC driver supports all SoC generations from Meson8 to G12A/G12B/SM1, because 80-90% of the code is shared across all revisions). Martin
