On Thu, 21 Nov 2019 at 20:01, Rob Herring <rob.e.herring@xxxxxxxxx> wrote: > > On Wed, Nov 20, 2019 at 12:49 AM Manish Narani <manish.narani@xxxxxxxxxx> wrote: > > > > Add optional properties for mmc hosts which are used to set clk delays > > for different speed modes in the controller. > > > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/mmc-controller.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > index 080754e0ef35..305b2016bc17 100644 > > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > @@ -333,6 +333,18 @@ patternProperties: > > required: > > - reg > > > > + "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$": > > + minItems: 2 > > + maxItems: 2 > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - minimum: 0 > > + maximum: 359 > > This is wrong. It can't be both minItems of 2 and a single uint32. > What's needed is: > > allOf: > - $ref: /schemas/types.yaml#/definitions/uint32-array > minItems: 2 > maxItems: 2 > items: > minimum: 0 > maximum: 359 Thanks Rob for clarifying! Manish, can you please send a fixup on top? Kind regards Uffe