Re: [PATCH] of: Reduce log level of of_phandle_iterator_next()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 19, 2019 at 10:00 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> These error messages are mostly useful for debugging malformed device
> tree data.

A malformed DT is an error, no?

> So change these messages from error to debug messages to
> avoid spamming the end user. Any error messages that might actually be
> useful to the user is probably going to come from the caller of these
> APIs. So leave it to them to decide if they need to print any error
> messages.

Generally that pattern results in every caller doing their own message
which is the wrong way around IMO. And recent patches fix some of
those cases[1].

Rob

[1] https://lkml.org/lkml/2019/7/30/41



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux