Dan / Jacek, On Tue, Nov 19, 2019 at 1:33 PM Dan Murphy <dmurphy@xxxxxx> wrote: > > Prefer device_* calls as opposed to of_* calls. Ok, I see now how this is done on lp8860 and lm3692x. So for this led driver to be correct, it should: - use device_* calls - use led_init_data (i.e. devm_led_classdev_register_ext) - drop pdata support for the led subdriver (nice to have) Unfortunately I can't, because the required infrastructure isn't present in the 4.19 vendor kernel I'm using. I only have a single tps6105x chip in my target system, so I don't have a requirement for devicetree led naming. So for v3 I will hard-code the led name to 'tps6105x::torch' which should comply with the naming convention.
