On Tue, Nov 19, 2019 at 2:38 PM Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > > label DT property was recently deprecated. We now encourage using > 'function' and/or 'color'. Please refer to > Documentation/devicetree/bindings/leds/common.txt. Ah, I see. I'm actually back-porting this from a 4.19 vendor kernel, which I believe does not have function/color support. If I introduce it here, I wouldn't be able to test it easily, and I'd have to forward/back-port. All I need is a single led in the system. So I'll just remove the 'label' code/description, and hard-code the led name to 'tps6105x'. If anyone wants to use this driver and wants named leds, they can always add it themselves. Jacek and Dan, does that satisfy your concerns?