Hi Adrian, On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx> wrote: Some nitpicks: > + > +config DRM_IMX_MIPI_DSI > + tristate "Freescale i.MX DRM MIPI DSI" This text seems too generic as there are i.MX SoCs that use different MIPI DSI IP. Maybe "Freescale i.MX6 DRM MIPI DSI" instead? > +module_platform_driver(imx_mipi_dsi_driver); > + > +MODULE_DESCRIPTION("i.MX MIPI DSI host controller driver"); i.MX6 MIPI DSI, please.