Re: [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mohammad,

On Sat, Nov 16, 2019 at 10:53 AM Andreas Färber <afaerber@xxxxxxx> wrote:
[...]
> > +
> > +/dts-v1/;
> > +
> > +#include "meson-gxbb-p201.dts"
>
> This is rather unusual, normally you would include the SoC's .dtsi, not
> another board.
you may even get another benefit from this:
we don't know the Ethernet PHY setup on the P201 board (because nobody
has an actual P201 board) so we don't use interrupts etc.

however, since you do have a access to your KII Pro you can do better
than P201 and define the Ethernet bits similar to Odroid-C2 for
example: [0]
if you board doesn't use a Realtek RTL8211F PHY then please also
update the comment in the Ethmac node
testing the PHY interrupt (which means less polling -> your CPU has
more time to do other things) is easy:
* cat /proc/interrupts
* unplug and re-plug the Ethernet cable
* cat /proc/interrupts again and check the Ethernet PHY interrupt
(should be +2 compared to the first invocation)


Martin


[0] https://github.com/torvalds/linux/blob/f9717178b9be9477877d4c3776c61ff56d854ddf/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts#L122




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux