Quoting Taniya Das (2019-11-15 00:11:31) > Hi Stephen, > > Thanks for the review. > > On 11/6/2019 6:09 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2019-10-31 05:21:13) > >> diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c > >> new file mode 100644 > >> index 0000000..bef034b > >> --- /dev/null > >> +++ b/drivers/clk/qcom/videocc-sc7180.c > >> @@ -0,0 +1,263 @@ > > > >> + video_pll0_config.alpha = 0x4000; > >> + video_pll0_config.user_ctl_val = 0x00000001; > >> + video_pll0_config.user_ctl_hi_val = 0x00004805; > > > > Same question, why on stack? > > > > Will update the same. Sounds like nothing to do. > > >> + > >> + clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config); > >> + > >> + /* video_cc_xo_clk */ > > > > What are we doing? Enabling it? > > > > yes, enabling it. Did not model and mark it CRITICAL. Ok. Please describe that in the comment. > >> +} > >> +module_exit(video_cc_sc7180_exit); > > > > Same question, module platform driver perhaps? > > > > I will move it to subsys_initcall(). > Hmm ok.
