Arun, On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun.kk@xxxxxxxxxxx> wrote: > + memory { > + reg = <0x20000000 0x80000000>; As mentioned in the other thread, I think this should be 0 0 > +&pinctrl_0 { > + tpm_irq: tpm-irq { > + samsung,pins = "gpx1-0"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; Is there any way to use the #defines PIN_PULL_NONE here? > +&pinctrl_3 { > + backlight_pwm: backlight-pwm { > + samsung,pins = "gpb2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; The PWM probably belongs in exynos5420-pinctrl.dtsi (though you'd need to call it by a more generic name since it could be used for something other than a backlight). -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html