Thanks, Vinod, I found there are "/**" in the beginning of files but not for commenting function purpose. Those comments cause kernel-doc W=1 warning. I've fixed them and rebased to latest source. will send the patch after running regression tests soon. -- Green On Thu, Nov 14, 2019 at 3:15 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > On 07-11-19, 16:49, Green Wan wrote: > > Add PDMA driver support for SiFive HiFive Unleashed RevA00 board. Mainly follows > > DMAengine controller doc[1] to implement and take other DMA drivers as reference. > > Such as > > > > - drivers/dma/fsl-edma.c > > - drivers/dma/dw-edma/ > > - drivers/dma/pxa-dma.c > > > > Using DMA test client[2] to test. Detailed datasheet is doc[3]. Driver supports: > > > > - 4 physical DMA channels, share same DONE and error interrupt handler. > > - Support MEM_TO_MEM > > - Tested by DMA test client > > - patches include DT Bindgins document and dts for fu450-c000 SoC. Separate dts > > patch for easier review and apply to different branch or SoC platform. > > - retry 1 time if DMA error occurs. > > I have applied this expect dt change. I see some warns due to missing > kernel-doc style comments with W=1, please fix that and send update on > top of these > > Thanks > -- > ~Vinod
