Hi Doug,
On Wed, Apr 30, 2014 at 10:18 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> Arun,
>
> On Wed, Apr 23, 2014 at 9:17 PM, Arun Kumar K <arun.kk@xxxxxxxxxxx> wrote:
>> Adds the google peach-pit board dts file which uses
>> exynos5420 SoC.
>>
>> Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx>
>> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>> ---
>> Changes from v1
>> ---------------
>> - Addressed review comments from Doug, Sachin & Tushar
>> - Removed adc and lid-switch nodes
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 182 ++++++++++++++++++++++++++++
>> 2 files changed, 183 insertions(+)
>> create mode 100644 arch/arm/boot/dts/exynos5420-peach-pit.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 35c146f..3220e29 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -74,6 +74,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>> exynos5250-smdk5250.dtb \
>> exynos5250-snow.dtb \
>> exynos5420-arndale-octa.dtb \
>> + exynos5420-peach-pit.dtb \
>> exynos5420-smdk5420.dtb \
>> exynos5440-sd5v1.dtb \
>> exynos5440-ssdk5440.dtb
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> new file mode 100644
>> index 0000000..fbb0469
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -0,0 +1,182 @@
>> +/*
>> + * Google Peach Pit Rev 6+ board device tree source
>> + *
>> + * Copyright (c) 2014 Google, Inc
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include "exynos5420.dtsi"
>> +
>> +/ {
>> + model = "Google Peach Pit Rev 6+";
>> +
>> + compatible = "google,pit-rev16",
>> + "google,pit-rev15", "google,pit-rev14",
>> + "google,pit-rev13", "google,pit-rev12",
>> + "google,pit-rev11", "google,pit-rev10",
>> + "google,pit-rev9", "google,pit-rev8",
>> + "google,pit-rev7", "google,pit-rev6",
>> + "google,pit", "google,peach","samsung,exynos5420",
>> + "samsung,exynos5";
>> +
>> + memory {
>> + reg = <0x20000000 0x80000000>;
>> + };
>
> One other thing that came up at ELC: it might not be so wise to
> include actual values here. We're expecting that the bootloader will
> probe memory and tell you whether you're on a 2GB board or a 4GB
> board. IIRC the proper thing to do here is to use 0 for both, so:
>
> reg = <0 0>;
>
Ok I will make this change.
With this change can I have your Reviewed-by on the v3 patchset?
Regards
Arun
> -Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
