On 12/11/2019 09:00, Eason Yen wrote: > Hi Matthias, > > > I will upstream mt6779 sound card driver on Mark's ASoC repo: > http://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git > > But it is still under internal reviewing and not yet upstream. Got it, thanks for the explanation. Then please add this patch to the series you are working on for the sound card driver. Two reasons to do so. First this way we make sure no not-used files will land in the kernel. Second, Mark will need to apply this patch to his local tree if he tries to do some compile testing. If it's not part of the series he will have to search for it in my repo or the mailinglist. Regards, Matthias > So, I think that this patch could be upstream first. > > Maybe, other mtk sip clients can use this header and add their's > specific MTSK_SIP_* ID. > > Regards, > Eason > > > On Mon, 2019-11-11 at 16:17 +0100, Matthias Brugger wrote: >> >> On 11/11/2019 03:30, Eason Yen wrote: >>> soc: mediatek: add SMC fid table for SIP interface >>> >>> 1. Add a header file to provide SIP interface to ATF >>> for clients, please define MTK_SIP_XXX with specific ID >>> >>> 2. Add AUDIO SMC fid >>> mtk sip call example: >>> arm_smccc_smc(MTK_SIP_AUDIO_CONTROL, >>> MTK_AUDIO_SMC_OP_DRAM_REQUEST, >>> 0, 0, 0, 0, 0, 0, &res) >> >> Are you planning to upstream a driver consuming this interface? >> If so, I propose to add this patch to the submission of the driver. Sounds good? >> >> Regards, >> Matthias >> >>> >>> >>> Eason Yen (1): >>> soc: mediatek: add SMC fid table for SIP interface >>> >>> include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h >>> >
