On 12.11.19 11:02, Kever Yang wrote: > Markus, > > > On 2019/11/12 下午4:16, Markus Reichl wrote: >> Hi Kever, >> >> have a rk3399-roc-pc running mainline U-Boot and kernel and vdd_log is >> showing 1118 mV. > > The rk3399-roc-pc have the same vdd_log circuit in schematic, so it > should like the patch 1/3 of > > this patch set. > > I don't understand who is setting this value, maybe the default value > without pwm regulator enabled? > >> Is this a danger for the board? >> How to fix it? > > The best way is to set correct min/max microvolt of the > regulator(measure with PWM output low and high), I didn't look into the schematic of this board, but if it is similar to RockPro64, setting the pwm regulator to the max voltage of 1.7V will probably kill the rk3399 immediately. So I recommend not to do this... Regards, Soeren > > (note that if no driver touch the regulator, the PWM is default > input, not output;) > to > and set a init-microvolt for U-Boot driver, and I think no kernel > driver touch this regulator now. > > > Thanks, > > - Kever > >> Btw. vin-supply for this pwm-regulator is ignored and I could not >> find it >> in bindings doc. >> >> Gruß, > >