On 28/10/2019 08:29, Eason Yen wrote: > 1. Add a header file to provide SIP interface to ATF > 2. Add AUDIO SMC fid > > Change-Id: I218e9f571cea079268a5414725a81e9b35702e33 Please delete Change-Id entry. Apart from that, I don't really get the reason for this patch. Which driver is supposed to use this header file? Please provide more background information. Regards, Matthias > Signed-off-by: Eason Yen <eason.yen@xxxxxxxxxxxx> > --- > include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h > > diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h > new file mode 100644 > index 0000000..00ee0f4 > --- /dev/null > +++ b/include/linux/soc/mediatek/mtk_sip_svc.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2019 MediaTek Inc. > + */ > + > +#ifndef __MTK_SIP_SVC_H__ > +#define __MTK_SIP_SVC_H__ > + > +#include <linux/kernel.h> > + > +/* Error Code */ > +#define SIP_SVC_E_SUCCESS 0 > +#define SIP_SVC_E_NOT_SUPPORTED -1 > +#define SIP_SVC_E_INVALID_PARAMS -2 > +#define SIP_SVC_E_INVALID_Range -3 > +#define SIP_SVC_E_PERMISSION_DENY -4 > + > +#ifdef CONFIG_ARM64 > +#define MTK_SIP_SMC_AARCH_BIT 0x40000000 > +#else > +#define MTK_SIP_SMC_AARCH_BIT 0x00000000 > +#endif > + > +/* AUDIO related SMC call */ > +#define MTK_SIP_AUDIO_CONTROL \ > + (0x82000517 | MTK_SIP_SMC_AARCH_BIT) > +#endif > +/* __MTK_SIP_SVC_H__ */ >