On Thu, Nov 7, 2019 at 8:21 PM Wen He <wen.he_1@xxxxxxx> wrote: > > > > > -----Original Message----- > > From: Stephen Boyd <sboyd@xxxxxxxxxx> > > Sent: 2019年11月8日 6:58 > > To: Leo Li <leoyang.li@xxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > > Michael Turquette <mturquette@xxxxxxxxxxxx>; Rob Herring > > <robh+dt@xxxxxxxxxx>; Wen He <wen.he_1@xxxxxxx>; > > devicetree@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; > > linux-devel@xxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Subject: [EXT] RE: [v6 2/2] clk: ls1028a: Add clock driver for Display output > > interface > > > > Caution: EXT Email > > > > Quoting Wen He (2019-11-06 19:13:48) > > > > > > > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index > > > > > 0138fb14e6f8..d23b7464aba8 100644 > > > > > --- a/drivers/clk/Makefile > > > > > +++ b/drivers/clk/Makefile > > > > > @@ -45,6 +45,7 @@ obj-$(CONFIG_COMMON_CLK_OXNAS) > > += > > > > > clk-oxnas.o > > > > > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o > > > > > obj-$(CONFIG_COMMON_CLK_PWM) += clk-pwm.o > > > > > obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o > > > > > +obj-$(CONFIG_CLK_LS1028A_PLLDIG) += clk-plldig.o > > > > > > > > Wrong ordering. This section of Makefile requires ordering by > > > > driver file > > > > name: > > > > > > > > # hardware specific clock types > > > > # please keep this section sorted lexicographically by file path > > > > name > > > > > > > > > > Hi Leo, > > > > > > Stephen once suggest the Kconfig variable name should be given a more > > > specific name like CLK_LS1028A_PLLDIG, so I have to changed it. > > > > > > Hi Stephen, > > > > > > How do you think? > > > > > > > > > Config name looks fine to me, but you haven't sorted this based on the file > > name, i.e. clk-plldig.o, so please insert this in the right place in this file. > > Wow, Understand now.. > > Should be sort this file like below, right? > obj-$(CONFIG_COMMON_CLK_PWM) += clk-pwm.o > obj-$(CONFIG_CLK_LS1028A_PLLDIG) += clk-plldig.o > obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o No. The correct order should be: clk-plldig.o clk-pwm.o clk-qoriq.o Regards, Leo
