> From: Rob Herring <robh+dt@xxxxxxxxxx> > > Using Makefile's wildcard with absolute path to detect the presence of > > libyaml results in false-positive detection when cross-compiling e.g. > > in yocto environment. > > As this is a host tool, it's not really about cross-compiling, but sandboxing the > host env? IOW, I cross-compile all the time and don't have an issue. Yes, you are correct, this is to address sandboxing, too late to correct? > > > Use pkg-config to locate libyaml to address this scenario. > > The reason I didn't use pkg-config in the first place is it adds another > dependency. AIUI, it's only needed for gconfig/xconfig which are probably > not widely used especially for CI. Looks like objtool needs it too, but that's > x86 only though arm64 support is being worked on. So I guess it is pretty > much becoming a requirement. Exactly, the patch was inspired by usage of pkg-config in that shell scripts assuming that it's more correct way to handle libyaml dependency... I see it also used for building tools. Should I maybe add new patch to fallback to wildcard when pkg-config is not found? > > So I've applied it. I added suppressing stderr in case pkg-config isn't present. Thank you! Pavel
