Re: [PATCH] ASoC: mc13783: Add devicetree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Wed, 30 Apr 2014 15:33:52 +0100 от Lee Jones <lee.jones@xxxxxxxxxx>:
> On Wed, 30 Apr 2014, Alexander Shiyan wrote:
> 
> > Wed, 30 Apr 2014 15:24:56 +0100 от Lee Jones <lee.jones@xxxxxxxxxx>:
> > > > > > > > > This patch adds devicetree support for mc13783-codec.
> > > > > > > > 
> > > > > > > > Applied, thanks.
> > > > > > > 
> > > > > > > No Mark, no!
> > > > > > 
> > > > > > What a problem, Lee?
> > > > > 
> > > > > There's no problem with the patch, don't worry.
> > > > > 
> > > > > Neither Mark, nor I can apply this patch independently, we need to
> > > > > create a shared branch somewhere, or we'll risk conflicts at merge
> > > > > time.
> > > > 
> > > > I can separate this patch for ASoC and MFD if need.
> > > > But this will work only if both is applied.
> > > 
> > > Are there build dependencies, or only functional ones?
> > 
> > Functional only.
> > At this time "fsl,mc13xxx-uses-codec" option for PMIC produce a kernel crash :)
> 
> If patches can be broken up notwithstanding build errors, they should
> be.  It makes things sooo much easier.

In fact that the patch for MFD is not obvious if the codec have no DT support...

If you do we see this problem (pdata == NULL and we pass this to the
driver in DT case), for me it not worst to separate this. What we do?
Should this be a two patches in one series or one for MFD and one for ASoC then?

---

��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux