From: MarkLee <Mark-MC.Lee@xxxxxxxxxxxx> Date: Thu, 7 Nov 2019 18:51:35 +0800 > + for (i = 0; i < 2; i++) { This is a regression, because in the existing code... > - for (i = 0; i < MTK_MAC_COUNT; i++) { the proper macro is used instead of a magic constant. You're doing so many things in one change, it's hard to review and audit. If you're going to consolidate code, do that only in one change. Then make other functional changes such as putting the chip into GDMA_DROP_ALL mode during the stop operation etc.