On Wed, Nov 6, 2019 at 7:03 AM Joel Stanley <joel@xxxxxxxxx> wrote: > The ast2600 has some minor differences to previous versions. The > interrupt handler must acknowledge the timer interrupt in a status > register. Secondly the control register becomes write to set only, > requiring the use of a separate set to clear register. > > Signed-off-by: Joel Stanley <joel@xxxxxxxxx> > +/* > + Control register set to clear for ast2600 only. > + */ > +#define TIMER_CR_CLR (0x3c) If it is AST2600-specific then please add some AST2600 prefix such as AST2600_TIMER_CR_CLR (0x3c) With that: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
