Hi Rob, Thank you for your review! > From: Rob Herring, Sent: Thursday, November 7, 2019 9:57 AM <snip> > > + dma-names: > > + minItems: 2 > > + maxItems: 4 > > + items: > > + - enum: [ch0, ch1, ch2, ch3] > > This is saying the 1st item is one of the 4 values and the others are > undefined. I think you want: > > items: > - const: ch0 > - const: ch1 > - const: ch2 > - const: ch3 You're correct. So, I'll fix it. > > + > > + dr_mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: | > > + tells Dual-Role USB controllers that we want to work on a particular > > + mode. Valid arguments are "host", "peripheral" and "otg". In case this > > + attribute isn't passed via DT, USB DRD controllers should default to OTG. > > Assume we have a common binding for this and all you need is: > > dr_mode: true I got it. I'll fix it on v3. Best regards, Yoshihiro Shimoda
