On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: > Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@xxxxxxxxxx> a écrit : > > > > On Thu, 31 Oct 2019 13:30:38 +0100 > > Benjamin Gaignard <benjamin.gaignard@xxxxxx> wrote: > > > > > Convert the STM32 IIO trigger binding to DT schema format using json-schema > > > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx> > > I'm far from great on these as still haven't taken the time I should to learn > > the yaml syntax properly. A few comments inline however based mostly on this > > doesn't quite look like other ones I've seen recently. > > > > Thanks, > > > > Jonathan > > > > > --- > > > .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > > > .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > > > 2 files changed, 44 insertions(+), 25 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > > > > > diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > new file mode 100644 > > > index 000000000000..1c8c8b55e8cd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: STMicroelectronics STM32 Timers IIO timer bindings > > > + > > > +maintainers: > > > + - Benjamin Gaignard <benjamin.gaignard@xxxxxx> > > > + - Fabrice Gasnier <fabrice.gasnier@xxxxxx> > > > + > > > +properties: > > > + $nodemane: > > > > nodename? > > That will be in v2 No, $nodename is correct. The '$' signifies something we generate and add in. IOW, not a real property. I guess we could have used 'name' here and stuck with traditional OpenFirmware. > > > > > > + pattern: "^timer@[0-9]+$" > > > + type: object > > > + > > > + description: > > > + must be a sub-node of an STM32 Timer device tree node > > > + > > > + properties: > > > + compatible: > > > + oneOf: > > > > enum is I think preferred for these. > > as you like it will be in v2 > > > > > > + - const: st,stm32-timer-trigger > > > + - const: st,stm32h7-timer-trigger > > > + > > > + reg: true > > > > Normally some info for what the reg value is.. > I can't put "description" on this field because the syntax doesn't allow it. > I will add a comment in v2 to explain what reg is. items: - maximum: <max timer number> Rob
