On 05/11/2019 4.19, Rob Herring wrote:
> On Fri, Nov 01, 2019 at 10:41:28AM +0200, Peter Ujfalusi wrote:
>> New binding document for
>> Texas Instruments K3 NAVSS Unified DMA – Peripheral Root Complex (UDMA-P).
>>
>> UDMA-P is introduced as part of the K3 architecture and can be found in
>> AM654 and j721e.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>> ---
>> Rob,
>>
>> can you give me some hint on how to fix these two warnings from dt_binding_check:
>>
>> DTC Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml
>> Documentation/devicetree/bindings/dma/ti/k3-udma.example.dts:23.13-72: Warning (ranges_format): /example-0/interconnect@30800000:ranges: "ranges" property has invalid length (24 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 2)
>> CHECK Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml
>
> The default #address-cells is 1 for examples. So you need to
> either override it or change ranges parent address size.
wrapping the cbass_main_navss inside:
cbass_main {
#address-cells = <2>;
#size-cells = <2>;
...
};
fixes it.
>>
>> Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml: interconnect@30800000: $nodename:0: 'interconnect@30800000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>
> Use 'bus' for the node name of 'simple-bus'.
I took the navss node from the upstream dts (I'm going to fix it there
as well).
It has simple-bus for the navss, which is not quite right as NAVSS is
not a bus, but a big subsystem with multiple components (UDMAP, ringacc,
INTA, INTR, timers, etc).
What about to change the binding doc to simple-mfd like this
cbass_main_navss: navss@30800000 {
compatible = "simple-mfd";
#address-cells = <2>;
#size-cells = <2>;
...
};
and fix up the DT when I got to the point when I can send the patches to
enable DMA for am654 and j721e?
>>
>> .../devicetree/bindings/dma/ti/k3-udma.yaml | 190 ++++++++++++++++++
>> 1 file changed, 190 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>> new file mode 100644
>> index 000000000000..e00fe3b2364e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>> @@ -0,0 +1,190 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings:
>
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
OK.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/dma/ti/k3-udma.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments K3 NAVSS Unified DMA Device Tree Bindings
>> +
>> +maintainers:
>> + - Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>> +
>> +description: |
>> + The UDMA-P is intended to perform similar (but significantly upgraded)
>> + functions as the packet-oriented DMA used on previous SoC devices. The UDMA-P
>> + module supports the transmission and reception of various packet types.
>> + The UDMA-P is architected to facilitate the segmentation and reassembly of
>> + SoC DMA data structure compliant packets to/from smaller data blocks that are
>> + natively compatible with the specific requirements of each connected
>> + peripheral.
>> + Multiple Tx and Rx channels are provided within the DMA which allow multiple
>> + segmentation or reassembly operations to be ongoing. The DMA controller
>> + maintains state information for each of the channels which allows packet
>> + segmentation and reassembly operations to be time division multiplexed between
>> + channels in order to share the underlying DMA hardware. An external DMA
>> + scheduler is used to control the ordering and rate at which this multiplexing
>> + occurs for Transmit operations. The ordering and rate of Receive operations
>> + is indirectly controlled by the order in which blocks are pushed into the DMA
>> + on the Rx PSI-L interface.
>> +
>> + The UDMA-P also supports acting as both a UTC and UDMA-C for its internal
>> + channels. Channels in the UDMA-P can be configured to be either Packet-Based
>> + or Third-Party channels on a channel by channel basis.
>> +
>> + All transfers within NAVSS is done between PSI-L source and destination
>> + threads.
>> + The peripherals serviced by UDMA can be PSI-L native (sa2ul, cpsw, etc) or
>> + legacy, non PSI-L native peripherals. In the later case a special, small PDMA
>> + is tasked to act as a bridge between the PSI-L fabric and the legacy
>> + peripheral.
>> +
>> + PDMAs can be configured via UDMAP peer registers to match with the
>> + configuration of the legacy peripheral.
>> +
>> +allOf:
>> + - $ref: "../dma-controller.yaml#"
>> +
>> +properties:
>> + "#dma-cells":
>> + const: 1
>> + description: |
>> + The cell is the PSI-L thread ID of the remote (to UDMAP) end.
>> + Valid ranges for thread ID depends on the data movement direction:
>> + for source thread IDs (rx): 0 - 0x7fff
>> + for destination thread IDs (tx): 0x8000 - 0xffff
>> +
>> + PLease refer to the device documentation for the PSI-L thread map and also
>> + the PSI-L peripheral chapter for the correct thread ID.
>> +
>> + compatible:
>> + oneOf:
>> + - const: ti,am654-navss-main-udmap
>> + - const: ti,am654-navss-mcu-udmap
>> + - const: ti,j721e-navss-main-udmap
>> + - const: ti,j721e-navss-mcu-udmap
>
> enum works better than oneOf+const. Better error messages.
Like this:
compatible:
oneOf:
- description: for AM654
items:
- enum:
- ti,am654-navss-main-udmap
- ti,am654-navss-mcu-udmap
- description: for J721E
items:
- enum:
- ti,j721e-navss-main-udmap
- ti,j721e-navss-mcu-udmap
>
>> +
>> + reg:
>> + maxItems: 3
>> +
>> + reg-names:
>> + items:
>> + - const: gcfg
>> + - const: rchanrt
>> + - const: tchanrt
>> +
>> + msi-parent: true
>> +
>> + ti,sci:
>> + description: |
>
> Doesn't need to be a literal block (can drop the '|').
OK
>
>> + phandle to TI-SCI compatible System controller node
>> + maxItems: 1
>
> Drop this, not an array.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>> +
>> + ti,sci-dev-id:
>> + description: |
>> + TI-SCI device id of UDMAP
>> + maxItems: 1
>
> Drop this.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + ti,ringacc:
>> + description: |
>> + phandle to the ring accelerator node
>> + maxItems: 1
>
> Drop this.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>> +
>> + ti,sci-rm-range-tchan:
>> + description: |
>> + Array of UDMA tchan resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> These should not be under 'items'. Drop 'items'.
>
> Any constraints on the values of the array elements?
The subtype is usually smaller than 30 for the current K3 device
line-up, but I would not set an upper limit, it all depends on system
firmware for the given family member.
I'll drop the items for the rm-ranges
>
>> +
>> + ti,sci-rm-range-rchan:
>> + description: |
>> + Array of UDMA rchan resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> Same here.
>
>> +
>> + ti,sci-rm-range-rflow:
>> + description: |
>> + Array of UDMA rflow resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> And here.
>
>> +
>> +required:
>> + - compatible
>> + - "#dma-cells"
>> + - reg
>> + - reg-names
>> + - msi-parent
>> + - ti,sci
>> + - ti,sci-dev-id
>> + - ti,ringacc
>> + - ti,sci-rm-range-tchan
>> + - ti,sci-rm-range-rchan
>> + - ti,sci-rm-range-rflow
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
