On Sun, Nov 03, 2019 at 09:54:59PM +0100, Linus Walleij wrote: > This adds device tree bindings for the Sony ACX424AKP panel. > Let's use YAML. > > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v4->v5: > - Fix up all warnings etc incurred from the now working schema check > and DTS compilation. > - I still have a vert annoying error message in the Sony > panel bindings that uses this schema: > sony,acx424akp.example.dt.yaml: panel@0: $nodename:0: 'panel@0' does not match '^dsi-controller(@.*)?$' > As this is modeled very closely to > Documentation/devicetree/bindings/net/mdio.yaml > and that one doesn't emit this type of warning for its ethernet-phy@0 > etc I am pretty much clueless and just can't see what the problem > is. I thought I told you what the problem is on the last version. See below. > - If I can't figure this out the only viable next step is to drop the > ambition to create yaml bindings simply because I'm unable to do > it, and go back to traditional text bindings :( > ChangeLog v3->v4: > - Adjust to adjusted DSI bindings. > ChangeLog v2->v3: > - Put the example inside a dsi-controller so we have a complete > example that verifies to the DSI panel generic binding. > ChangeLog v1->v2: > - Suggest a stand-alone YAML bindings file for DSI panels in > a separate patch, and use that to reference the > boolean "enforce-video-mode" attribute for DSI panels > --- > .../display/panel/sony,acx424akp.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > new file mode 100644 > index 000000000000..1c123139b80a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony ACX424AKP 4" 480x864 AMOLED panel > + > +maintainers: > + - Linus Walleij <linus.walleij@xxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: ../dsi-controller.yaml# This schema is for a panel node, not the dsi-controller. You need to drop this line. It should be included by DSI controllers. > + > +properties: > + compatible: > + const: sony,acx424akp > + reg: true > + reset-gpios: true > + vddi-supply: > + description: regulator that supplies the vddi voltage > + enforce-video-mode: true > + > +required: > + - compatible > + - reg > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi-controller@a0351000 { > + compatible = "ste,mcde-dsi"; > + reg = <0xa0351000 0x1000>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "sony,acx424akp"; > + reg = <0>; > + vddi-supply = <&foo>; > + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>; > + }; > + }; > + > +... > -- > 2.21.0 >
