On Tue, Oct 29, 2019 at 03:04:31PM +0000, Tremblay, Eric wrote: > dt-bindings: hwmon: Add TMP512/513 Did you mean for this to be the subject. Otherwise you've got the same subject for both patches. > > Add dt-binding for TMP512/513 sensor chips > > Signed-off-by: Eric Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/hwmon/ti,tmp513.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > new file mode 100644 > index 000000000000..e5f3c72ff548 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2018 Linaro Ltd. Really? > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/ti,tmp513.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TMP513/512 system monitor sensor > + > +maintainers: > + - Eric Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx> > + > +description: | > + The TMP512 (dual-channel) and TMP513 (triple-channel) are system monitors that include > + remote sensors, a local temperature sensor, and a high-side current shunt monitor. > + These system monitors have the capability of measuring remote temperatures, > + on-chip temperatures, and system voltage/power/current consumption. Wrap lines at <80 chars. > + > + Datasheets: > + http://www.ti.com/lit/gpn/tmp513 > + http://www.ti.com/lit/gpn/tmp512 > + > + > +properties: > + compatible: > + enum: > + - ti,tmp512 > + - ti,tmp513 > + > + reg: > + maxItems: 1 > + > + shunt-resistor-micro-ohms: > + description: | > + If 0, the calibration process will be skiped and the current and power > + measurement engine will not work. Temperature and voltage measurement > + will continue to work. > + The shunt value also need to respect : rshunt <= pga-gain * 40 * 1000 * 1000. > + If not, it's not possible to compute a valid calibration value. > + default: 1000 > + > + ti,pga-gain: > + description: | > + The gain value for the PGA function. This is 8, 4, 2 or 1. > + The PGA gain affect the shunt voltage range. > + The range will be equal to: pga-gain * 40mV > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 4, 8] > + default: 8 > + > + ti,bus-voltage-range-volt: > + description: | > + This is the operating range of the bus voltage > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [16, 32] > + default: 32 If this is in volts then it needs '-volt' defined in property-units.txt or just use microvolt. My preference is the latter as you have enough range. Also, 'voltage' is kind of redundant if with the units. > + > + ti,nfactor: > + description: | > + Array of three(TMP513) or two(TMP512) n-Factor value for each remote > + temperature channel. > + See datasheet Table 11 for n-Factor range list and value interpretation. > + allOf: > + - $ref: /schemas/types.yaml#definitions/uint8-array > + - minItems: 2 > + maxItems: 3 > + items: > + default: 0 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c { > + tmp513@5c { > + compatible = "ti,tmp513"; > + reg = <0x5C>; > + shunt-resistor-micro-ohms = <330000>; > + ti,bus-voltage-range-volts = <32>; > + ti,pga-gain = <8>; > + ti,nfactor = [01 F3 00]; > + }; > + }; > -- > 2.17.1 >
