Hi Matti! Good initiative (and I will see a ton of janitorial patches as a result of this...) On Fri, Nov 1, 2019 at 12:50 PM Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > At least for me it is difficult to remember the meaning of GPIO > direction values. Define GPIO_IN and GPIO_OUT so that occasional > GPIO contributors would not need to always check the meaning of > hard coded values 1 and 0. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> (...) > +#define GPIO_IN 1 > +#define GPIO_OUT 0 Please spell it out or people will be confused: GPIO_LINE_DIRECTION_IN GPIO_LINE_DIRECTION_OUT Yours, Linus Walleij
