Hi Hugo, On Wed, Oct 30, 2019 at 11:43:31PM +0100, Hugo Grostabussiat wrote: > The rtl_bt driver already supports some Realtek controllers on ACPI > platforms. > This commit adds bindings for DT-only platforms. > > Signed-off-by: Hugo Grostabussiat <bonstra@xxxxxxxxxxxxxxxxx> > --- > .../bindings/net/realtek-bluetooth.txt | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt You should write that binding using a YAML description. Free-form device tree bindings are more or less deprecated now. > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt > new file mode 100644 > index 000000000000..01d4ed146705 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt > @@ -0,0 +1,25 @@ > +Realtek Bluetooth controllers > +============================= > + > +This documents the binding structure and properties for the serial > +attached Bluetooth controllers from Realtek. > + > +Required properties: > +- compatible: currently, only "realtek,rt8723bs-bt" is supported > + > +Optional properties: > +- enable-gpio: gpio line controlling the power down (BT_DIS#) signal > +- device-wake: gpio line controlling the device wakeup (BT_WAKE) signal > +- config-name: postfix added to the name of the firmware file > + containing the chip configuration > + > +Example: > + > +&uart1 { > + bluetooth { > + compatible = "realtek,rtl8723bs-bt"; > + enable-gpio = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */ > + device-wake-gpio = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > + config-name = "teres_a64_i"; IIRC, that has been discussed before and the standard "model" property was to be preferred. Maxime