RE: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

[Peng Fan <peng.fan@xxxxxxx>]

> Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
> 
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> 
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
> 

Sorry for this. I not use sdcard when I did the test.

> It can be fixed by reverting this DT patch or by setting CONFIG_AT803X_PHY
> to y instead of m.

I prefer setting CONFIG_AT803X_PHY.

Thanks,
Peng.

> 
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
> 
> > ---
> >
> > V2:
> >   U-Boot->bootloader
> >   Add R-b tag
> >
> >   arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> >   	pinctrl-0 = <&pinctrl_fec1>;
> >   	phy-mode = "rgmii-id";
> >   	phy-handle = <&ethphy0>;
> > +	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> >   	fsl,magic-packet;
> >   	status = "okay";