Hi Uffe,
Thanks for your comments. Please see below inline.
> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Sent: Wednesday, October 30, 2019 8:27 PM
> To: Manish Narani <MNARANI@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>;
> Michal Simek <michals@xxxxxxxxxx>; Jolly Shah <JOLLYS@xxxxxxxxxx>; Nava
> kishore Manne <navam@xxxxxxxxxx>; Rajan Vaja <RAJANV@xxxxxxxxxx>;
> linux-mmc@xxxxxxxxxxxxxxx; DTML <devicetree@xxxxxxxxxxxxxxx>; Linux
> Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; git <git@xxxxxxxxxx>
> Subject: Re: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional
> properties for Arasan SDHCI
>
> On Tue, 29 Oct 2019 at 11:30, Manish Narani <manish.narani@xxxxxxxxxx>
> wrote:
> >
> > Add optional properties for Arasan SDHCI which are used to set clk delays
> > for different speed modes in the controller.
> >
> > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/mmc/arasan,sdhci.txt | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > index b51e40b2e0c5..c0f505b6cab5 100644
> > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > @@ -46,6 +46,22 @@ Optional Properties:
> > properly. Test mode can be used to force the controller to function.
> > - xlnx,int-clock-stable-broken: when present, the controller always
> reports
> > that the internal clock is stable even when it is not.
> > + - arasan-clk-phase-legacy: Input/Output Clock Delay pair in degrees for
> Legacy Mode.
> > + - arasan-clk-phase-mmc-hs: Input/Output Clock Delay pair degrees for
> MMC HS.
> > + - arasan-clk-phase-sd-hs: Input/Output Clock Delay pair in degrees for SD
> HS.
> > + - arasan-clk-phase-uhs-sdr12: Input/Output Clock Delay pair in degrees
> for SDR12.
> > + - arasan-clk-phase-uhs-sdr25: Input/Output Clock Delay pair in degrees
> for SDR25.
> > + - arasan-clk-phase-uhs-sdr50: Input/Output Clock Delay pair in degrees
> for SDR50.
> > + - arasan-clk-phase-uhs-sdr104: Input/Output Clock Delay pair in degrees
> for SDR104.
> > + - arasan-clk-phase-uhs-ddr50: Input/Output Clock Delay pair in degrees
> for SD DDR50.
> > + - arasan-clk-phase-mmc-ddr52: Input/Output Clock Delay pair in degrees
> for MMC DDR52.
> > + - arasan-clk-phase-mmc-hs200: Input/Output Clock Delay pair in degrees
> for MMC HS200.
> > + - arasan-clk-phase-mmc-hs400: Input/Output Clock Delay pair in degrees
> for MMC HS400.
>
> I don't mind if you convert these to common mmc bindings.
>
> I think other controllers/platforms may find them useful, at least at
> some point, if not already.
That will be a good thing to do indeed. Will send v5 with making these properties as common.
Thanks,
Manish
>
> > +
> > + Above mentioned are the clock (phase) delays which are to be
> configured in the
> > + controller while switching to particular speed mode. The range of values
> are
> > + 0 to 359 degrees. If not specified, driver will configure the default value
> > + defined for particular mode in it.
> >
> > Example:
> > sdhci@e0100000 {
> > --
> > 2.17.1
> >
>
> Kind regards
> Uffe
