Quoting kgunda@xxxxxxxxxxxxxx (2019-10-30 00:06:05) > On 2019-10-29 22:08, Stephen Boyd wrote: > > Quoting Rajendra Nayak (2019-10-23 02:02:16) > >> diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi > >> b/arch/arm64/boot/dts/qcom/pm6150.dtsi > >> new file mode 100644 > >> index 000000000000..20eb928e5ce3 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi > >> @@ -0,0 +1,85 @@ > >> +// SPDX-License-Identifier: BSD-3-Clause > >> +// Copyright (c) 2019, The Linux Foundation. All rights reserved. > >> + > >> +#include <dt-bindings/iio/qcom,spmi-vadc.h> > >> +#include <dt-bindings/input/linux-event-codes.h> > >> +#include <dt-bindings/interrupt-controller/irq.h> > >> +#include <dt-bindings/spmi/spmi.h> > >> +#include <dt-bindings/thermal/thermal.h> > >> + > >> +&spmi_bus { > >> + pm6150_lsid0: pmic@0 { > >> + compatible = "qcom,pm6150", "qcom,spmi-pmic"; > >> + reg = <0x0 SPMI_USID>; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + pm6150_pon: pon@800 { > >> + compatible = "qcom,pm8998-pon"; > >> + reg = <0x800>; > >> + mode-bootloader = <0x2>; > >> + mode-recovery = <0x1>; > > > > Can this have status = "disabled"? Or is the idea that if the pmic > > power > > button isn't used it should be disabled in the board dts file? > > > Yes. The idea is to go with latter option. Disable it in the board dts > file if the > pmic power button is not used. Ok. Thanks. > >> + > >> + interrupt-names = "pm6150_gpio1", > >> "pm6150_gpio2", > >> + "pm6150_gpio3", > >> "pm6150_gpio4", > >> + "pm6150_gpio5", > >> "pm6150_gpio6", > >> + "pm6150_gpio7", > >> "pm6150_gpio8", > >> + "pm6150_gpio9", > >> "pm6150_gpio10"; > > > > And this? And have gpio-ranges and use the irqdomain work. Basically, > > should look like pm8998. > Ok.. We can go ahead with the pm8998 way as well. We will address it in > next series. Yes please use the pm8998 way..