On Wed, Oct 30, 2019 at 11:56:34AM +0530, Manivannan Sadhasivam wrote:
> Hi Sakari,
>
> Thanks for the review!
You're welcome!
>
> On Tue, Oct 29, 2019 at 02:13:20PM +0200, Sakari Ailus wrote:
> > Hi Manivannan,
> >
> > On Fri, Oct 25, 2019 at 11:29:08PM +0530, Manivannan Sadhasivam wrote:
...
> > > +static struct i2c_driver imx296_i2c_driver = {
> > > + .probe_new = imx296_probe,
> > > + .remove = imx296_remove,
> > > + .driver = {
> > > + .name = "imx296",
> > > + .pm = &imx296_pm_ops,
> > > + .of_match_table = of_match_ptr(imx296_of_match),
> >
> > No need for of_match_ptr here.
> >
>
> AFAIK, of_match_ptr is needed for !OF case. Else we need to manually add
> #ifdef clut to make it NULL. Does the situation changed now?
ACPI based systems can also make use of the compatible string for matching
drivers with devices through of_match_table. This may sometimes be the most
practical approach. I.e. you don't need ifdefs either.
--
Regards,
Sakari Ailus
