Thanks for the review! On 04/28/2014 11:50 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> + if (backlog) >> + backlog->complete(backlog, -EINPROGRESS); > > The completion function needs to be called with BH disabled. > > Cheers, > This is new for me because I saw similar code in cryptd.c where in cryptd_queue_worker() (workqueue context) the backlog->complete() is called outside of local_bh_disable(). -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html