Hi Rob, On Fri, 2019-10-25 at 12:12 -0500, Rob Herring wrote: > On Thu, Oct 24, 2019 at 3:27 PM Chris Packham > <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote: > > > > This GPIO controller is present on a number of Broadcom switch ASICs > > with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio > > blocks but different enough to require a separate driver. > > > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > > --- > > > > Notes: > > Changes in v4: > > - rename brcm,xgs-iproc.yaml -> brcm,xgs-iproc-gpio.yaml as suggested > > > > Changes in v3: > > - incorporate review comments from Rob and Bart > > > > Changes in v2: > > - Document as DT schema > > - Include ngpios, #gpio-cells and gpio-controller properties > > > > .../bindings/gpio/brcm,xgs-iproc-gpio.yaml | 70 +++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > new file mode 100644 > > index 000000000000..ec1fd3a64aa2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/brcm,xgs-iproc.yaml# > > Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml: $id: > path/filename 'gpio/brcm,xgs-iproc.yaml' doesn't match actual filename > > Otherwise, > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> I'll send a quick v5 of just this patch with the minor correction and your reviewed-by.
