Hi Corentin,
On Fri, 2019-10-25 at 20:51 +0200, Corentin Labbe wrote:
> The Security System is an hardware cryptographic offloader present
> on Allwinner SoCs A80 and A83T.
> It is different from the previous sun4i-ss.
>
> This driver supports AES cipher in CBC and ECB mode.
>
> Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> ---
[...]
> +static int sun8i_ss_probe(struct platform_device *pdev)
> +{
> + struct sun8i_ss_dev *ss;
> + int err, irq;
> + u32 v;
> +
> + ss = devm_kzalloc(&pdev->dev, sizeof(*ss), GFP_KERNEL);
> + if (!ss)
> + return -ENOMEM;
[...]
> +
> + ss->reset = devm_reset_control_get(&pdev->dev, NULL);
It looks like this driver could use devm_reset_control_get_shared() to
get a (clk-like) refcounted reset control. Otherwise, please use
devm_reset_control_get_exclusive() instead of devm_reset_control_get().
See the kerneldoc comment for reset_control_get_shared() for details.
regards
Philipp
