Hi Rob,
On 2019/10/26 4:19, Rob Herring wrote:
> On Wed, Oct 16, 2019 at 6:26 AM Jianxin Pan <jianxin.pan@xxxxxxxxxxx> wrote:
>>
>> Hi Rob,
>>
>> On 2019/10/15 1:39, Rob Herring wrote:
>>> On Thu, Oct 10, 2019 at 04:21:15AM -0400, Jianxin Pan wrote:
>>>> Add the bindings for the Amlogic Secure power domains, controlling the
>>>> secure power domains.
>>>>
>>>> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the
>>>> power domain registers are in secure world.
>>>>
>>>> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>>>> ---
>>>> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 42 ++++++++++++++++++++++
>>>> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++
>>>> 2 files changed, 74 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>>>> +
>>>> + secure-monitor:
>>>> + description: phandle to the secure-monitor node
>>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>>
>>> Why not just a child node of this node?
>>>
>> Thanks for the review.
>>
>> I followed the style of the previous series of meson：
>>
>> 46 efuse: efuse {
>> 47 compatible = "amlogic,meson-gxbb-efuse";
>> 48 clocks = <&clkc CLKID_EFUSE>;
>> 49 #address-cells = <1>;
>> 50 #size-cells = <1>;
>> 51 read-only;
>> 52 secure-monitor = <&sm>;
>> 53 };
>
> Looks like that was not reviewed by me and is only in linux-next.
> Please make functions exposed by secure world a child of the secure
> firmware node.
>
> Really for power domains, you only need to add a '#power-domain-cells'
> property to the secure monitor node.
>
OK, I will update them in the next version.
Thanks for the review.
> Rob
>
> .
>
