Hi, On 04/28/2014 09:36 PM, Maxime Ripard wrote: > On Sat, Apr 26, 2014 at 12:16:07PM +0200, Hans de Goede wrote: >> From: David Lanzendörfer <david.lanzendoerfer@xxxxxx> >> >> The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in >> designware idmac controller, which is identical to the one found in the mmc-dw >> hosts. However the rest of the host is not identical to mmc-dw, it deals with >> sending stop commands in hardware which makes it significantly different >> from the mmc-dw devices. >> >> HdG: Various cleanups and fixes. >> >> Signed-off-by: David Lanzendörfer <david.lanzendoerfer@xxxxxx> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> .../devicetree/bindings/mmc/sunxi-mmc.txt | 43 + >> drivers/mmc/host/Kconfig | 7 + >> drivers/mmc/host/Makefile | 2 + >> drivers/mmc/host/sunxi-mmc.c | 1125 ++++++++++++++++++++ >> 4 files changed, 1177 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sunxi-mmc.txt >> create mode 100644 drivers/mmc/host/sunxi-mmc.c >> >> diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt >> new file mode 100644 >> index 0000000..f0c06e7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt >> @@ -0,0 +1,43 @@ >> +* Allwinner sunxi MMC controller >> + >> +The highspeed MMC host controller on Allwinner SoCs provides an interface >> +for MMC, SD and SDIO types of memory cards. >> + >> +Supported maximum speeds are the ones of the eMMC standard 4.5 as well >> +as the speed of SD standard 3.0. >> +Absolute maximum transfer rate is 200MB/s >> + >> +Required properties: >> + - compatible : "allwinner,sun4i-a10-mmc" or "allwinner,sun5i-a13-mmc" >> + - reg : mmc controller base registers >> + - clocks : a list with 2 phandle + clock specifier pairs >> + - clock-names : must contain "ahb" and "mod" > > Again, this is not a module0 clock, so the clock name is misleading. Ah, I see what you're getting at, yes giving it a different name here makes sense I'll change it to mmc in the next version of the patch-set. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
