Am 25.10.19 um 23:24 schrieb Andreas Färber: > Am 25.10.19 um 23:16 schrieb Rob Herring: >> On Sun, Oct 20, 2019 at 06:08:10AM +0200, Andreas Färber wrote: >>> +properties: >>> + compatible: >>> + oneOf: >>> + - const: realtek,rtd1295-watchdog >> >> You can drop the 'oneOf' here unless you're planning to add another >> entry with 2 compatible strings. > > It's a preparation for adding rtd1195-watchdog when needed, to make > future diffs smaller. There's also RTD1395 and RTD1619 to be tested. > >> With that, >> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Self-NAK. The example doesn't pass dt_binding_check: It doesn't like the tabs retained from the original binding. Replacing them with four spaces makes it pass. Will post a v3. As for the compatibles, currently in the rtd1195.dtsi patch I'm reusing "realtek,rtd1295-watchdog", to avoid a dependency on the watchdog tree. Long-term that's kind of ugly as it uses a later model number. That leaves us with two alternatives: a) "realtek,rtd1195-watchdog", "realtek,rtd1295-watchdog" - this requires oneOf. Allows to distinguish between RTD1195 and RTD1295 while remaining compatible with the current driver. b) "realtek,rtd1195-watchdog" - requires the driver change now and requires the binding to be merged before I can use it in the DT but doesn't need oneOf here. Guenter, any preference here? Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
