On Wed, Oct 23, 2019 at 10:43:48AM +0800, Ikjoon Jang wrote: > Add the DT binding document for Hammer's TABLET_MODE switch. This doesn't have any properties. Why does it need to be in DT? Just have the EC driver instantiate it. > > Signed-off-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx> > --- > .../devicetree/bindings/input/cros-cbas.yaml | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/cros-cbas.yaml > > diff --git a/Documentation/devicetree/bindings/input/cros-cbas.yaml b/Documentation/devicetree/bindings/input/cros-cbas.yaml > new file mode 100644 > index 000000000000..3bc989c6a295 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/cros-cbas.yaml > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier: GPL-2.0 (GPL-2.0-only OR BSD-2-Clause) for new bindings please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/cros-cbas.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ChromeOS Hammer's Base Attached Switch > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > + > +description: > + This device is used to signal when a detachable base is attached to a > + Chrome OS tablet. The node for this device must be under a cros-ec node > + like google,cros-ec-spi or google,cros-ec-i2c. This should probably just be part of an EC schema where it can be enforced that this is a child node. It could be either embedded into it or referenced. I'd lean toward the former given this is only a compatible string... > + > +properties: > + compatible: > + const: google,cros-cbas > + > +required: > + - compatible Add here: additionalProperties: false. > -- > 2.23.0.866.gb869b98d4c-goog >
