On Fri, Oct 25, 2019 at 7:56 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, Jan 14, 2019 at 6:30 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > The renesas,rzn1-uart binding only differs in compatible string from the > > snps-dw-apb-uart binding. Move it there, converting it to json-schema in > > the process. > > > > Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: linux-serial@xxxxxxxxxxxxxxx > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > @@ -15,6 +15,11 @@ allOf: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - renesas,r9a06g032-uart > > + - renesas,r9a06g033-uart > > + - const: renesas,rzn1-uart > > - items: > > - enum: > > - rockchip,px30-uart > > With ARCH=arm and shmobile_defconfig, "make dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml" > complains: > > arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible: > ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is > not valid under any of the given schemas > arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible: > ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is > not valid under any of the given schemas > arch/arm/boot/dts/r9a06g032-rzn1d400-db.dt.yaml: compatible: > ['renesas,r9a06g032-uart', 'renesas,rzn1-uart', 'snps,dw-apb-uart'] is > not valid under any of the given schemas > > Do you know what's wrong? The addition doesn't allow for "snps,dw-apb-uart". Guess I relied on the binding doc being accurate. So we need to either drop it from dts files if the generic compatible is never useful (maybe simple cases like earlycon?) or add it here. Rob
