On Tue, Oct 22, 2019 at 10:07 AM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > Add DT binding for leds-meter. What's an leds meter? Need a better explanation to understand if this makes sense at all, but some comments on the schema below. > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Bjorn Andersson <bjorn@xxxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Cc: Jean-Jacques Hiblot <jjhiblot@xxxxxx> > Cc: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> > Cc: Pavel Machek <pavel@xxxxxx> > Cc: Dan Murphy <dmurphy@xxxxxx> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > --- > .../devicetree/bindings/leds/leds-meter.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-meter.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-meter.yaml b/Documentation/devicetree/bindings/leds/leds-meter.yaml > new file mode 100644 > index 0000000..d5dfa261 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-meter.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0 (GPL-2.0-only OR BSD-2-Clause) for new bindings. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-meter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic LED level meter > + > +maintainers: > + - Akinobu Mita <akinobu.mita@xxxxxxxxx> > + > +description: > + Generic LED level meter consists of multiple LED devices by different drivers. > + > +properties: > + compatible: > + const: meter-leds > + > + leds: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 No need for this as the minimum for arrays is already 1. And it doesn't work either. You'd need the $ref under an 'allOf'. > + description: List of phandles to LED node that are members of a level meter. > + > + brightness-weights: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + description: Each integer represents a contribution ratio within a level > + meter. > + > +required: > + - compatible > + - leds Add a: additionalProperties: false > + > +examples: > + - | > + leds { Needs to be a name that's not also a property name. 'leds-meter' or 'meter-leds' perhaps. And define the name above under a $nodename property. > + compatible = "meter-leds"; > + leds = <&led0>, <&led1>, <&led2>, <&led3>; > + brightness-weights = <3 1 1 1>; > + }; > + > +... > -- > 2.7.4 >
