On Tue, Oct 22, 2019 at 11:22 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > Hi, > > * Adam Ford <aford173@xxxxxxxxx> [191007 15:06]: > > The some in the OMAP3 family have a bandgap thermal sensor, but > > omap2plus has it disabled. > > > > This patch enables the OMAP3_THERMAL by default like the rest of > > the OMAP family. > > Looks like this breaks off mode during idle for omap3, and that's > probably why it never got enabled. The difference in power > consumption during idle is about 7mW vs 32mW for the SoC as > measured from torpedo shunt for main_battery_som. > > I think the right fix might be simply to add handling for > CPU_CLUSTER_PM_ENTER to the related thermal driver to disable > it during idle like we have for gpio-omap.c for example. I am not sure I know where to start on fixing that issue. Would you entertain enabling the driver if we set the device tree to 'disabled' by default? This way if people want to to use it, it can be enabled on a per-device option. Once the power stuff gets resolved, we might be able to enable it by default. For people who are planning on using the DM3730 @ 1GHz in high temp environments, I am not sure they'll care about low power. I'll try to look into it when I have time, but I was hoping a compromise might be a reasonable work-around. adam > > Regards, > > Tony > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > index 8f1c2b6f9e56..7e14a8c8bb29 100644 > > --- a/arch/arm/configs/omap2plus_defconfig > > +++ b/arch/arm/configs/omap2plus_defconfig > > @@ -292,6 +292,7 @@ CONFIG_THERMAL_GOV_FAIR_SHARE=y > > CONFIG_THERMAL_GOV_USER_SPACE=y > > CONFIG_CPU_THERMAL=y > > CONFIG_TI_THERMAL=y > > +CONFIG_OMAP3_THERMAL=y > > CONFIG_OMAP4_THERMAL=y > > CONFIG_OMAP5_THERMAL=y > > CONFIG_DRA752_THERMAL=y > > -- > > 2.17.1 > >
