* Benoit Parrot <bparrot@xxxxxx> [191022 16:45]: > Tony Lindgren <tony@xxxxxxxxxxx> wrote on Tue [2019-Oct-22 09:37:54 -0700]: > > * Benoit Parrot <bparrot@xxxxxx> [191022 16:34]: > > > Tony Lindgren <tony@xxxxxxxxxxx> wrote on Tue [2019-Oct-22 09:30:48 -0700]: > > > > * Benoit Parrot <bparrot@xxxxxx> [191022 16:28]: > > > > > Tony, > > > > > > > > > > Ping, > > > > > > > > > > I already had comments from Rob but i would like your feedback before > > > > > sending a v2. > > > > > > > > Looks good to me in general other than what Rob commented > > > > on. Did not spot any node naming issues here :) > > > > > > Would I need to split off the clk*.c/.h as well here though? > > > > Yeah please do patches with just drivers/clk/ti and > > include/dt-bindings/clock changes in them. then Tero > > can queue them into an immutable branch that I can merge > > in too and use as a base for the dts changes. > > Although the .h is in include/dt-binding. Does it still belong in the same > patch as drivers/clk/ti/clk-7xx.c then? > > Just making sure.... Yes if it's needed to compile the drivers/clk/ti patch. Otherwise it can stay with the dts changes. Regards, Tony