Hi Krzysztof, On 21.10.19 12:38, krzk@xxxxxxxxxx wrote: > On Wed, Oct 16, 2019 at 03:07:25PM +0000, Schrempf Frieder wrote: >> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >> >> The baseboard for the Kontron N6310 SoM is also used for other SoMs >> such as N6311 and N6411. In order to share the code, we move the >> definitions of the baseboard to a separate dtsi file. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >> --- >> arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts | 405 +---------------- >> arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 412 ++++++++++++++++++ >> 2 files changed, 413 insertions(+), 404 deletions(-) >> create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> [...] >> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> new file mode 100644 >> index 000000000000..08a326ce2cbe >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> @@ -0,0 +1,412 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2017 exceet electronics GmbH >> + * Copyright (C) 2018 Kontron Electronics GmbH >> + * Copyright (c) 2019 Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> + */ >> + > > This file does not include anything else but uses defines (GPIO flags, > clocks, pins). Usually sources should not rely on inclusions coming from > unrelated files so here you should include necessary headers. In case of > future refactorings or reuse one might not know which defines you wanted > to use (in other platforms for example there might be multiple defines > in multiple header files with same name). Right, I need to include the proper headers here. I will also check the other files. Thanks for reviewing! Frieder
