On Wed, Oct 16, 2019 at 8:15 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Oct 15, 2019 at 6:04 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > > > On Wed, Oct 9, 2019 at 6:31 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > On Tue, Oct 01, 2019 at 06:39:22PM -0500, Adam Ford wrote: > > > > This patch adds documentation of device tree bindings for the WVGA panel > > > > Logic PD Type 28 display. > > > > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > > --- > > > > V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 > > > > V3: Correct build errors from 'make dt_binding_check' > > > > > > The example still fails to build here. > > > > I cannot replicate the build error on 5.4-RC3 at least for this > > binding on V4 of the patch. I get build error on other bindings. > > > > $ make dt_binding_check ARCH=arm > > scripts/kconfig/conf --syncconfig Kconfig > > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml > > /home/aford/src/linux/Documentation/devicetree/bindings/net/adi,adin.yaml: > > ignoring, error in schema 'adi,rx-internal-delay-ps' > > warning: no schema found in file: > > Documentation/devicetree/bindings/net/adi,adin.yaml > > /home/aford/src/linux/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml: > > ignoring, error in schema '0' > > warning: no schema found in file: > > Documentation/devicetree/bindings/regulator/fixed-regulator.yaml > > CHKDT Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml > > .... > > CHKDT Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml > > CHKDT Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml > > CHKDT Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > > CHKDT Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml > > ... > > CHKDT Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml > > CHKDT Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: > > $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match > > actual filename > > Documentation/devicetree/bindings/Makefile:12: recipe for target > > 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' > > failed > > make[1]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] > > Error 1 > > Makefile:1263: recipe for target 'dt_binding_check' failed > > make: *** [dt_binding_check] Error 2 > > > > > > I took out some of the logs to make it less chatty. I don't know > > anything about yaml or what the expectations are, so if there is a > > test beyond 'make dt_binding_check' please let me know. > > Perhaps 'make -k' is needed because of the other failures. Or try on > top of linux-next which should all be fixed. Thanks. I didn't know about the '-k' I replaced GPIO_ACTIVE_HIGH with 0 and it seems to have fixed the error. Sorry about all the noise. Hopefully I did it right. There is a V5 patch waiting now starting at [1] [1] - https://patchwork.kernel.org/patch/11193399/ adam > > Rob
