On Thu, Oct 10, 2019 at 02:36:51PM -0500, Rob Herring wrote: > On Thu, 3 Oct 2019 08:12:53 +0200, =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= wrote: > > Convert the mpr121 binding to DT schema format using json-schema. > > > > Signed-off-by: Michal Vokáč <michal.vokac@xxxxxxxxx> > > --- > > Changes since v2: > > - None > > > > Changes since v1: > > - Extract the common input properties into the input.yaml schema. > > - Fix the wakeup-source description. > > - Fix the example to pass validation. Put the mpr121 device sub-node > > into a i2c {} node. > > > > The linux,keycodes property is not valid as it is. If I put the minItems > > and maxItems into the common schema, it is valid and the min/max length > > check works fine. Rob, could you advice how to fix this please? > > > > The error is not very specific.. > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml > > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml > > /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml: ignoring, error in schema 'linux,ke > > warning: no schema found in file: /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml > > /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/p > > make[3]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255 > > /home/vokac/development/sources/linux-fslc/Makefile:1264: recipe for target 'dt_binding_check' failed > > > > .../bindings/input/fsl,mpr121-touchkey.yaml | 66 ++++++++++++++++++++++ > > .../devicetree/bindings/input/mpr121-touchkey.txt | 30 ---------- > > 2 files changed, 66 insertions(+), 30 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml > > delete mode 100644 Documentation/devicetree/bindings/input/mpr121-touchkey.txt > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Applied, thank you. -- Dmitry