Hi, On Fri, Apr 25, 2014 at 8:11 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 25 Apr 2014, Vivek Gautam wrote: > >> From: Kamil Debski <k.debski@xxxxxxxxxxx> >> >> Add the phy provider, supplied by new Exynos-usb2phy using >> Generic phy framework. >> Keeping the support for older USB phy intact right now, in order >> to prevent any functionality break in absence of relevant >> device tree side change for ehci-exynos. >> Once we move to new phy in the device nodes for ehci, we can >> remove the support for older phys. >> >> Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> >> [gautam.vivek@xxxxxxxxxxx: Addressed review comments from mailing list] >> [gautam.vivek@xxxxxxxxxxx: Kept the code for old usb-phy, and just >> added support for new exynos5-usb2phy in generic phy framework] >> [gautam.vivek@xxxxxxxxxxx: Edited the commit message] >> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> > >> +static int exynos_ehci_phyg_off(struct phy *phy[]) >> +{ >> + int i; >> + int ret = 0; >> + >> + for (i = 0; ret == 0 && i < PHY_NUMBER; i++) >> + if (phy[i]) >> + ret = phy_power_off(phy[i]); >> + >> + return ret; >> +} > > Same comment as in the OHCI driver about ret. Ok, will change this. > >> @@ -175,6 +269,7 @@ skip_phy: >> fail_add_hcd: >> if (exynos_ehci->phy) >> usb_phy_shutdown(exynos_ehci->phy); >> + exynos_ehci_phyg_off(exynos_ehci->phy_g); >> fail_io: >> clk_disable_unprepare(exynos_ehci->clk); >> fail_clk: >> @@ -195,6 +290,8 @@ static int exynos_ehci_remove(struct platform_device *pdev) >> if (exynos_ehci->phy) >> usb_phy_shutdown(exynos_ehci->phy); >> >> + exynos_ehci_phyg_off(exynos_ehci->phy_g); >> + > > In both these places, you need to test exynos_ehci->phyg before calling > exynos_ehci_phyg_off(). > > Maybe it would help to add exynos_ehci_phy_enable/disable routines, > like in the OHCI driver. Will move these statements as a part of enable()/disable() routines, put necessary check there. -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html