Dear Myungjoo, On Mon, Apr 28, 2014 at 7:04 AM, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> wrote: >> This patchset adds devfreq support on Exynos5250 and Exynos5420. >> The patches add the missing INT clock support for exynos5250 and >> also add a new 5420 driver. We also have patches which add the PPMU >> node and fix a typo in the exynos5250 driver. >> >> The patches have been tested on Exynos5250 based Snow board and SMDK5420 >> EVT1 boards. They have been prepared on linux-next(20140424) with the >> devfreq for-next branch and Shaik Ameer Basha's clock cleanup patches >> merged (http://www.spinics.net/lists/arm-kernel/msg325313.html). >> >> There are a couple of concerns with these patches: >> 1) The patches are using clock aliases to expose the required clocks to the >> devfreq driver. >> 2) The patches are making use of different compatible strings for the PPMU >> node to differentiate between multiple SoCs even though the PPMU is the same. >> >> Kindly suggest a way to move forward with respect to the above. > > The Exynos PPMU drivers have been located in drivers/devfreq/exynos > as devfreq drivers have been the only users of PPMU. There > are developers trying to design common PPMU frameworks, including > Chanwoo, it is not yet submitted. > > Because other Exynos5 SoCs have their bus/memif PPMU defined in > drivers/devfreq/exynos, adding another ont in another directory > seems not appropriate. Thanks for your reply. I agree with you, I would like to re-use the current exynos5 devfreq driver code as far as possible for 5420 as well. I do see a post from Chanwoo Choi (https://lkml.org/lkml/2014/3/12/171) regarding adding dt support for exynos4. But, looks like there has not be any new patchset for a while now. Chanwoo, is there a plan to post a new version of your patchset ? I would be interested in using the same for my work on exynos5. Regards, Abhilash > > > Cheers, > MyungJoo. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html