On Sat, Oct 05, 2019 at 04:55:08PM +0800, Tzung-Bi Shih wrote:
> Add an optional property "ec-codec". If specified, mt8183 could use the
> "wake on voice" feature offered by EC codec.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
> ---
> .../bindings/sound/mt8183-mt6358-ts3a227-max98357.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt b/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
> index 17ff3892f439..decaa013a07e 100644
> --- a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
> +++ b/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
> @@ -6,12 +6,15 @@ Required properties:
>
> Optional properties:
> - mediatek,headset-codec: the phandles of ts3a227 codecs
> +- mediatek,ec-codec: the phandle of EC codecs.
> + See google,cros-ec-codec.txt for more details.
Not the best designed audio binding here. We really should just have
links to codecs and then you can look at the codec nodes to determine
the type.
>
> Example:
>
> sound {
> compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
Don't you need to add EC codec to this? Just kidding. Just highlighting
the weirdness of this binding.
> mediatek,headset-codec = <&ts3a227>;
> + mediatek,ec-codec = <&ec_codec>;
> mediatek,platform = <&afe>;
> };
>
> --
> 2.23.0.581.g78d2f28ef7-goog
>
