RE: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio port node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio
> port node
> 
> Hi Biju,
> 
> On Thu, Oct 10, 2019 at 3:04 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > > Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove
> > > audio port node
> 
> > > On Tue, Oct 8, 2019 at 3:43 PM Biju Das <biju.das@xxxxxxxxxxxxxx>
> wrote:
> > > > > Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1:
> > > > > Remove audio port node On Fri, Oct 4, 2019 at 4:53 PM Biju Das
> > > > > <biju.das@xxxxxxxxxxxxxx> wrote:
> > > > > > This patch removes audio port node from SoC device tree.
> > > > >
> > > > > Standard review comment: "Why?"
> > >
> > > Bcause it fixes a dtb warning?
> > >
> > >    Warning (unit_address_vs_reg): /soc/sound@ec500000/ports/port@0:
> > > node has
> > >    a unit name, but no reg property
> >
> > I also noticed this warning.
> >
> > We will get this warning, if we  apply the patch  "[v3,2/2] arm64:
> > dts: renesas: r8a774b1: Add Sound and Audio DMAC  device nodes" first
> and then this one.
> >
> > If it is other way around, then there won't be any warning. That is the
> reason I didn't mention it in the commit message.
> 
> I even see the warning with current renesas-devel ("make dtbs W=1"), which
> does not have "[v3,2/2] arm64: dts: renesas: r8a774b1: Add Sound and Audio
> DMAC device nodes" yet.
> 
> So I'll apply this patch with the warning message in the commit log, unless I'm
> missing something?

Thanks Geert.  Sorry for the confusion, I see the warning with current renesas-devel  branch for r8a774b1 SoC.

Regards,
Biju




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux